Fix backwards compatability with Lua.workspace.checkThirdParty (take 2!)#2409
Merged
sumneko merged 2 commits intoLuaLS:masterfrom Nov 9, 2023
Merged
Fix backwards compatability with Lua.workspace.checkThirdParty (take 2!)#2409sumneko merged 2 commits intoLuaLS:masterfrom
Lua.workspace.checkThirdParty (take 2!)#2409sumneko merged 2 commits intoLuaLS:masterfrom
Conversation
…ty`" This reverts commit 13a24ee.
I attempted to maintain backwards compatability in LuaLS#2354 and LuaLS#2406 but didn't fully understand the config type system. This approach uses `Type.Or` and I even tested it to confirm that it works! Thanks to @pysan3 for pointing out how a default would be used for invalid types and to @sumneko for pointing out `Type.Or`.
|
Very nice. Thank you!! |
This was referenced Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted to maintain backwards compatability in #2354 and #2406 but didn't fully understand the config type system.
This approach uses
Type.Orand I even tested it to confirm that it works!Thanks to @pysan3 for pointing out how a default would be used for invalid types (#2406 (comment)), and thanks to @sumneko for pointing out
Type.Or(#2406 (comment)).